widen ndarray dependency and fix warning #429

DavidBJaffe · 2021-05-19T02:23:22Z

Widen the ndarray dependency to accept up to 0.15. This caused a warning, which
said to replace an instance of genrows() by rows(), and that was done.

Also widen approx dependency.

coveralls · 2021-05-19T02:31:55Z

Coverage remained the same at 87.639% when pulling 6a7f7a7 on DavidBJaffe:dj/widen_ndarray_dependency into 9f1452b on rust-bio:master.

bluss · 2021-07-07T12:35:57Z

src/pattern_matching/pssm/mod.rs

@@ -296,7 +296,7 @@ pub trait Motif {
        let bits = Self::get_bits();
        let scores = self.get_scores();
        let mut tot = 0.0;
-        for row in scores.genrows() {
+        for row in scores.rows() {


I don't think this will work with ndarray 0.13 unfortunately - an alternative like scores.axis_iter(Axis(0)) should work in the whole version range.

widen ndarray dependency and fix warning

088202d

widen approx dependency

6a7f7a7

bluss reviewed Jul 10, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

widen ndarray dependency and fix warning #429

widen ndarray dependency and fix warning #429

DavidBJaffe commented May 19, 2021 •

edited

coveralls commented May 19, 2021 •

edited

bluss Jul 7, 2021 •

edited

widen ndarray dependency and fix warning #429

Are you sure you want to change the base?

widen ndarray dependency and fix warning #429

Conversation

DavidBJaffe commented May 19, 2021 • edited

coveralls commented May 19, 2021 • edited

bluss Jul 7, 2021 • edited

Choose a reason for hiding this comment

DavidBJaffe commented May 19, 2021 •

edited

coveralls commented May 19, 2021 •

edited

bluss Jul 7, 2021 •

edited