Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update Strum to Latest Version #37

Merged
merged 3 commits into from Jul 15, 2022

Conversation

evolvedmicrobe
Copy link
Contributor

Currently is < 0.24, but figure we'll need to cross that bridge eventually.

Currently is < 0.24, but figure we'll need to cross that bridge eventually.
@evolvedmicrobe evolvedmicrobe changed the title Update Strum to Latest Version Chore: Update Strum to Latest Version May 4, 2022
@evolvedmicrobe evolvedmicrobe changed the title Chore: Update Strum to Latest Version chore: Update Strum to Latest Version May 4, 2022
@evolvedmicrobe
Copy link
Contributor Author

See companion PR at: rust-bio/rust-bio#491

@coveralls
Copy link

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2654488259

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.8%) to 73.062%

Files with Coverage Reduction New Missed Lines %
src/annot/contig.rs 3 70.52%
src/annot/pos.rs 6 72.41%
Totals Coverage Status
Change from base Build 1473526015: -0.8%
Covered Lines: 773
Relevant Lines: 1058

💛 - Coveralls

Cargo.toml Outdated Show resolved Hide resolved
@adam-azarchs
Copy link
Contributor

If you want to actually be able to release a new version after this merges, you should update the PR title to build: rather than chore:, since the release bot ignores chores.

Co-authored-by: Adam Azarchs <adam.azarchs@10xgenomics.com>
@evolvedmicrobe evolvedmicrobe changed the title chore: Update Strum to Latest Version build: Update Strum to Latest Version Jul 12, 2022
@pmarks pmarks self-requested a review July 15, 2022 00:08
Copy link
Contributor

@pmarks pmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pmarks pmarks self-requested a review July 15, 2022 00:09
@pmarks pmarks merged commit 5e550cc into rust-bio:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants