Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX fast stable diffusion pod template TMALLOC ( memory problem fix ) #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nerdylive123
Copy link

like on AUTOMATIC1111/stable-diffusion-webui#6722 (comment).
This is a fix for memory problem when user switched or loaded models/lora multiple time, then the SD will crash after.

pls do tests on this fix, i don't use the minimal version, i usually use the normal version of libtcmalloc.

@ashleykleynhans
Copy link
Contributor

like on AUTOMATIC1111/stable-diffusion-webui#6722 (comment). This is a fix for memory problem when user switched or loaded models/lora multiple time, then the SD will crash after.

pls do tests on this fix, i don't use the minimal version, i usually use the normal version of libtcmalloc.

Minimal version works fine, but I wonder why you're installing the deb packages from TheLastBen's Github repo rather than simply installing the Ubuntu apt packages.

@nerdylive123
Copy link
Author

Well yeah, idk i think it would be great to use the deps from that repo

@ashleykleynhans
Copy link
Contributor

ashleykleynhans commented Apr 16, 2024

Well yeah, idk i think it would be great to use the deps from that repo

I would agree with you if they were related to the repo itself, but its pretty bad practice to use debian packages that are version locked and very likely outdated. Its best practice to install the latest packages from the Operating System repositories (in this case the Ubuntu apt repositories) to ensure that you get the latest security patches included.

@ercanozer
Copy link

@nerdylive123 @ashleykleynhans When can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants