New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add animated spinners to long running operations. #725
Draft
rohinb2
wants to merge
1
commit into
main
Choose a base branch
from
rohin/animations
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/hardware/cluster.py
📄 File: runhouse/resources/module.py (Click to Expand)
📄 File: runhouse/resources/packages/package.py (Click to Expand)
📄 File: runhouse/servers/http/http_client.py (Click to Expand)
Did you find this useful? React with a 👍 or 👎 |
rohinb2
force-pushed
the
rohin/animations
branch
from
April 12, 2024 14:46
931026d
to
2a6124e
Compare
This was referenced May 22, 2024
rohinb2
force-pushed
the
rohin/basic-auth-not-needed
branch
from
May 22, 2024 20:21
2c5d53a
to
af12858
Compare
dongreenberg
force-pushed
the
rohin/basic-auth-not-needed
branch
from
May 22, 2024 20:30
af12858
to
8e6934a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried several libraries for this, none were that great.
this is the best library that prints above the text while it's running, and animates even without iterating through something
this also includes a timer, so many of our operations are timed explicitly