Install Lambda requirements using env.install() #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelSasha
changed the title
BelSasha
changed the title
Comment on lines
+314
to
+324
| if ( | ||
| "./" in env.reqs | ||
| and env.reqs[0] != "./" | ||
| and env.reqs[0].split("/")[0].split()[0] != env.reqs[0].split()[0] | ||
| ): | ||
| reqs = env.reqs | ||
| path_to_txt = str( | ||
| Path(reqs[0].split(":")[1] + "requirements.txt").absolute() | ||
| ) | ||
| paths_to_code.append(path_to_txt) | ||
| env.reqs = [path_to_txt] + env.reqs[1:] |
There was a problem hiding this comment.
Not totally clear on what's going on here, but looks pretty specific to one structure/use case. I think it would be a lot more robust if we could just send the packages to the lambda into the home directory, as we do with regular clusters. We can't rsync into a lambda, but can either 1) send the necessary files over the zip interface or 2) zip them ourselves and send them via a call into the lambda as we do with the env. I don't think that should be in this PR but feel it's quite critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.