Avoid creating symlinks that point out of output TreeArtifact #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cp -r` copies the _symlinks_, not the destination of symlinks. This results in a TreeArtifact with symlinks to content _outside_ the TreeArtifact, which is not well defined in bazel[^1]. At least bazel 7.1.1's linux-sandbox (bazel --spawn_strategy=sandboxed on Linux) does not follow the symlinks and destroys the temporary directory containing the actual files after the action, leaving a TreeArtifact of dangling symlinks. `cp -rL` chases the symlinks and creates a TreeArtifact of regular files. This has the desired behaviour in all bazel versions/sandboxes. [^1]: See discussion in bazelbuild/bazel#15454. It is unclear whether we _want_ to resolve these symlinks or leave them dangling, and behaviour varies across bazel versions and execution environment.
aaliddell
approved these changes
May 13, 2024
|
Excellent thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp -rcopies the symlinks, not the destination of symlinks. This results ina TreeArtifact with symlinks to content outside the TreeArtifact, which is not
well defined in bazel1. At least bazel 7.1.1's linux-sandbox (bazel
--spawn_strategy=sandboxed on Linux) does not follow the symlinks and destroys
the temporary directory containing the actual files after the action, leaving a
TreeArtifact of dangling symlinks.
cp -rLchases the symlinks and creates a TreeArtifact of regular files. Thishas the desired behaviour in all bazel versions/sandboxes.
Footnotes
See discussion in https://github.com/bazelbuild/bazel/issues/15454. It is
unclear whether we want to resolve these symlinks or leave them dangling, and
behaviour varies across bazel versions and execution environment. ↩