Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor prefix_path when output_mode is NO_PREFIX_FLAT #310

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Honor prefix_path when output_mode is NO_PREFIX_FLAT #310

wants to merge 6 commits into from

Conversation

linzhp
Copy link
Contributor

@linzhp linzhp commented Jan 17, 2024

Currently prefix_path is honored when output mode is PREFIXED or NO_PREFIX, but not honored when it's NO_PREFIX_FLAT. This is inconsistent. This PR fixed that.

Furthermore, this PR is one way of fixing #309, because people will be able to set something below to get rid of the "k8s.io" path generated by grpc:

python_grpc_library(
    name = "py_lib",
    protos = [":proto_lib"],
    output_mode = "NO_PREFIX_FLAT",
    prefix_path = "k8s/io/apimachinary",
    python_version = "PY3",
)

@github-actions github-actions bot added dependencies Pull requests that update a dependency file lang-python Python rules specific labels Jan 17, 2024
@linzhp
Copy link
Contributor Author

linzhp commented Jan 19, 2024

@aaliddell is the CI broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file lang-python Python rules specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@linzhp @aaliddell