Get remote branch #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruifm
approved these changes
Dec 6, 2021
Comment on lines
+284
to
289
| local branch = get_remote_branch(remote) | ||
| if branch then | ||
| repo.rev = branch | ||
| end | ||
|
|
||
| return repo |
There was a problem hiding this comment.
why call the key rev when it's always a branch name or nil? I would prefer repo.branch
Comment on lines
+284
to
+287
| local branch = get_remote_branch(remote) | ||
| if branch then | ||
| repo.rev = branch | ||
| end |
There was a problem hiding this comment.
No need for conditionality here, always set it, even if nil, it will be checked later anyways 😉
Suggested change
| local branch = get_remote_branch(remote) | |
| if branch then | |
| repo.rev = branch | |
| end | |
| repo.branch = get_remote_branch(remote) |
| rev = rev, | ||
| rev = repo_url_data.rev or rev, |
There was a problem hiding this comment.
we wouldn't have to do this if the key was called branch. Then we can embed both the branch name and the rev sha in the url data that is passed to callbacks.
Which is good because then it is up to the callbacks to decide what they want to do (either use the branch name or the rev sha).
stevanmilic
pushed a commit
to stevanmilic/gitlinker.nvim
that referenced
this pull request
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25