Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese translation #277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Vietnamese translation #277

wants to merge 2 commits into from

Conversation

hellotinh03
Copy link

Added Vietnamese translation at src/_locales/vi/messages.json and my name in the CONTRIBUTORS.md file.

Copy link
Owner

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hellotinh03,
thanks for your first contribution to this project! 🎉 👍 🏅
I hope you'll like this project and enjoy hacking on it… 😃

Sorry for missing the PR so long, I was busy and totally missed this here.

Also notice there are more things to translate like the add-on listings on AMO (addons.mozilla.org) etc. See the contributing guide for more information.

BTW note if you want you can also write the Changelog entry already, just copy an existing one as explained as a side-note here.

Please subscribe to #138 to get notified for new updates on translations etc. 😃

BTW: Next time, try to avoid doing a pull request from the master branch, because you can run into problems when you have a "non-clean" master that does not follow this repo here (i.e. "upstream"). See this article for details. Anyway, this is only a tip for the next time. 😃

@rugk rugk added the i18n/l10n Internationalisation and localisation label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n/l10n Internationalisation and localisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants