Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add Codacy analysis #135

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

ci: Add Codacy analysis #135

wants to merge 6 commits into from

Conversation

rugk
Copy link
Owner

@rugk rugk commented Aug 12, 2022

copied from Unicodify

ref TinyWebEx/AddonTemplate#5

@rugk
ci: Add Codacy analysis
04f3f96 
copied from Unicodify
@rugk
Copy link
Owner Author

rugk commented Aug 12, 2022

Wtf is that? https://github.com/rugk/awesome-emoji-picker/runs/7813837903?check_suite_focus=true

Exception in thread "main" java.lang.IndexOutOfBoundsException: 6 and 08/12 21:14:43 ERROR c.c.a.core.files.FileCollector:96 - Could not read file /home/runner/work/awesome-emoji-picker/awesome-emoji-picker/src/common/modules/EnvironmentDetector, make sure it is readable by everybody.

tdulcet
tdulcet reviewed Aug 13, 2022
View reviewed changes
Copy link
Contributor

@tdulcet tdulcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe updating the versions will fix the errors...

.github/workflows/codacy-analysis.yml Outdated Show resolved Hide resolved
.github/workflows/codacy-analysis.yml Outdated Show resolved Hide resolved
.github/workflows/codacy-analysis.yml Show resolved Hide resolved
@tdulcet tdulcet mentioned this pull request Aug 13, 2022
Merged
@rugk
Copy link
Owner Author

rugk commented Aug 16, 2022 •
edited

TODO: introduce Dependabot everywhere

@rugk @tdulcet
ci: fix missing v prefix
49c7400 
Co-authored-by: Teal Dulcet <tdulcet@gmail.com>
@rugk rugk requested a review from tdulcet October 19, 2022 14:53
tdulcet
tdulcet suggested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@tdulcet tdulcet left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after these two minor changes.

.github/workflows/codacy-analysis.yml Show resolved Hide resolved
.github/workflows/codacy-analysis.yml Outdated Show resolved Hide resolved
@rugk rugk dismissed a stale review via da87e13 October 19, 2022 20:08
@rugk @tdulcet
chore: bump version again hehe
da87e13 
Co-authored-by: Teal Dulcet <tdulcet@gmail.com>
@rugk rugk requested a review from tdulcet October 19, 2022 20:08
tdulcet
tdulcet approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tdulcet tdulcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdulcet tdulcet tdulcet approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rugk @tdulcet