Include full address in ical event #1036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When possible include the full address of the event's location in the ical event instead of just the location name
janz93
reviewed
Feb 5, 2024
There was a problem hiding this comment.
@timkaechele Thank you very much for your first Contribution 🎉
The change in general looks great. I added some requests to make the code more stable in the future.
| @@ -10,7 +10,7 @@ def icalendar(*events) | |||
| item.dtstart = event.date | |||
| item.dtend = event.end_date | |||
| item.url = event_url(event) | |||
| item.location = event.location.name if event.location | |||
| item.location = event.location.calendar_event_address if event.location | |||
There was a problem hiding this comment.
To ensure that this feature will work in the future when the code base changes. Could you please add a test for this?
| @@ -30,6 +30,14 @@ def address | |||
| "#{street} #{house_number}, #{zip} #{city}" | |||
| end | |||
|
|
|||
| def calendar_event_address | |||
There was a problem hiding this comment.
To ensure that this feature will work in the future when the code base changes. Could you please add a test for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it changes
This PR changes the ical events to actually include the address if present and only in the absence of a full address fall back to the name of the location
Why?
Because ruby user group events in Berlin are always at a different location, and I have trouble finding the place and the name of the location is not as helpful compared to an actual address your phone's calendar can help you find.