chore: initial effort on reducing cardinality for warehouseID #4667
Conversation
|
Important Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
achettyiitr
changed the title
achettyiitr
force-pushed
the
chore.tracker-tags
branch
from
a7be112
to
c92aff2
Compare
achettyiitr
changed the title
achettyiitr
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4667 +/- ##
==========================================
+ Coverage 74.47% 74.57% +0.09%
==========================================
Files 413 413
Lines 48752 48752
==========================================
+ Hits 36310 36358 +48
+ Misses 10056 10013 -43
+ Partials 2386 2381 -5 ☔ View full report in Codecov by Sentry. |
| @@ -348,6 +350,7 @@ func (bcm *BackendConfigManager) persistSSLFileErrorStat( | |||
| "module": "warehouse", | |||
| "destType": destType, | |||
| "warehouseID": misc.GetTagName(destID, sourceName, destName, misc.TailTruncateStr(sourceID, 6)), | |||
| "sourceID": sourceID, | |||
| "destinationID": destID, | |||
There was a problem hiding this comment.
Looks like destID is in use in other places.
| "destinationID": destID, | |
| "destID": destID, |
There was a problem hiding this comment.
Yean, I noticed that as well. There are dis-similarities around destID vs destinationID.
There was a problem hiding this comment.
I was discussing the same with @lvrach around the mismatch of tags. We thought of following these steps:
- Add additional tags where there are mismatches, like in say in this particular case we will add let's say destID.
- Check operator, if we have alerts or dashboards requires those tags, we can replace them, like in say in this particular case we will replace
destinationIDwithdestID. - Once we have no dependency we will remove it from the code, like in say removing
destinationIDfrom stat.
There was a problem hiding this comment.
LGTM apart from one use of destinationID instead of destID for a stat tag.
achettyiitr
force-pushed
the
chore.tracker-tags
branch
from
c92aff2
to
2cd1b60
Compare
|
As @Sidddddarth mentions, why not use |
This might break any existing alerting or monitoring dashboard right which uses these labels. To be more specific this alert. |
achettyiitr
requested review from
lvrach,
fracasula,
cisse21,
mihir20,
BonapartePC and
Sidddddarth
Description
Initial Cardinality Reduction Effort: The primary focus is on reducing the cardinality associated with
warehouseID. This is necessary becausewarehouseID's cardinality is influenced by variables likesourceNameanddestinationName, which are subject to change. Additionally, the inclusion ofsourceNameanddestinationNamedoes not add significant value sincesourceIDanddestIDsuffice for identification purposes.Current Plan Overview:
warehouseIDis utilized,sourceIDanddestIDare ensured to be available. For any instances where these identifiers are absent, they are added.warehouseID: Once the new tags (sourceIDanddestID) are consistently populated, the next step involves removingwarehouseIDfrom the metrics dashboard and alerts. Instead,sourceIDanddestIDwill be used for contextual information if necessary. (PIPE-1089)warehouseIDfrom the application code. (PIPE-1090)This improved version provides clearer explanations and organizes the plan's steps for better readability and understanding.
Linear Ticket
Security