Testing: Add type annotations to transfertool
, mock
and fts3
#6702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6588.
This PR is a bit larger, the main bulk is
fts3.py
. The abstract methods defined intransfertool.py
largely have the same type hints in their implementations inmock
andfts3
, with a few exceptions in cases where the sub-classes modified the types expected in the methods.On the pyright failure:
This is an issue within the Conveyor Receiver where we're passing a
session
that might beNone
toget_db_fields_to_update
. I didn't want to potentially impact the functionality of this daemon, so I didn't add a check to ensure thatsession
exists before passing it, but I think this check should probably exist in the daemon. I think it's best to keep this out of here to limit the scope of the PR totransfertool
, but we might want to add it in the future.