Testing: Add type annotations to common/types #6701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change does not affect the current functioning of the program, as: - _calc_external is only used in a context where self.internal exists and is a string - _calc_internal is only used in a context where self.external exists However, this change prevents typechecking errors once type annotations are added, because: - in _calc_external, self.internal.split fails if self.internal is not a string - in _calc_internal, return self.external causes an error if the return type annotation is "str", because self.external might be None
rdimaio
force-pushed
the
patch-6588-common-types
branch
from
a63f95d
to
d16c5f5
Compare
|
Rebased in latest forcepush |
bari12
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6588