Separate lockfile parsing from vulnerability scanning #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i would like you to use the bundler-audit library for scanning lockfiles stored in a database, rather than beeing available as actual files. So i changed
Scanner#initializeto take aBundler::LockfileParseras argument und introducedFileScannerto do the file opening, reading and parsing.This change breaks API. I am not sure how many people (if any) are using the projects lib and what your policy is regarding breaking changes. If you like to stay backwards compatible i can update the PR.
Cheers, ushi