Long RuboCop/Standard output JSON does not parse correctly

[shir]

Your environment

• vscode-ruby version: 0.22.0
• Ruby version: 2.1.2
• Ruby version manager (if any): asdf 0.6.3
• VS Code version: 1.31.1
• Operating System: Mac OS 10.14.3
• Using language server? Yes

Expected behavior

Rubocop will lint a file

Actual behavior

Rubocop doesn't lint a file. And I have next error in Ruby language server output:

[Info  - 2:30:00 PM] Initializing Ruby language server...
[Info  - 2:30:00 PM] Rebuilding tree-sitter for local Electron version
[Info  - 2:30:00 PM] Rebuild succeeded!
Lint: executing rubocop -s <path_to_file> -f json -R -l...
/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/util/hostReportError.js:4
    setTimeout(function () { throw err; });
                             ^

TypeError: LINTER_MAP[name] is not a constructor
    at getLinter (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/out/Linter.js:24:12)
    at MergeMapSubscriber.rxjs_1.from.pipe.operators_1.mergeMap.l [as project] (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/out/Linter.js:31:37)
    at MergeMapSubscriber._tryNext (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/operators/mergeMap.js:69:27)
    at MergeMapSubscriber._next (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/operators/mergeMap.js:59:18)
    at MergeMapSubscriber.Subscriber.next (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/Subscriber.js:66:18)
    at Observable._subscribe (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/util/subscribeToArray.js:5:20)
    at Observable._trySubscribe (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/Observable.js:44:25)
    at Observable.subscribe (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/Observable.js:30:22)
    at MergeMapOperator.call (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/operators/mergeMap.js:39:23)
    at Observable.subscribe (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/server/node_modules/rxjs/internal/Observable.js:25:31)
[Info  - 2:30:01 PM] Connection to server got closed. Server will restart.
[Error - 2:30:01 PM] Request textDocument/foldingRange failed.
Error: Connection got disposed.
    at Object.dispose (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/main.js:876:25)
    at Object.dispose (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-languageclient/lib/client.js:71:35)
    at LanguageClient.handleConnectionClosed (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-languageclient/lib/client.js:2150:42)
    at LanguageClient.handleConnectionClosed (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-languageclient/lib/main.js:150:15)
    at closeHandler (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-languageclient/lib/client.js:2137:18)
    at CallbackList.invoke (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/events.js:62:39)
    at Emitter.fire (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/events.js:120:36)
    at closeHandler (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/main.js:226:26)
    at CallbackList.invoke (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/events.js:62:39)
    at Emitter.fire (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/events.js:120:36)
    at IPCMessageReader.fireClose (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/messageReader.js:111:27)
    at ChildProcess.constructor.eventEmitter.on (/Users/shir/.vscode/extensions/rebornix.ruby-0.22.0/client/node_modules/vscode-jsonrpc/lib/messageReader.js:213:45)
    at ChildProcess.emit (events.js:187:15)
    at maybeClose (internal/child_process.js:961:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:248:5)

And this message appears several times

[shir]

Plugin configuration:

{
  "ruby.intellisense": "rubyLocate",
  "ruby.interpreter.commandPath": "/Users/shir/.asdf/shims/ruby",
  "ruby.lint": {
    "rubocop": {
      "lint": true,
      "rails": true,
    },
    "ruby": true,
  },
  "ruby.useLanguageServer": true,
  "ruby.useBundler": true,
  "ruby.pathToBundler": "/Users/shir/.asdf/shims/bundle"
}

[wingrunr21]

Can you post your configuration?

Great thanks!

[shir]

@wingrunr21 see above

[wingrunr21]

If you remove the Ruby lint entry does the error resolve? It’s redundant with rubocop and I’m not supporting it in the language server.

[shir]

@wingrunr21 yes. Error have disappeared. But have next message in logs and I don't see lint errors:

Lint: executing rubocop -s <path_to_file> -f json -R -l...
Lint: Received invalid JSON from rubocop:

No such plugin: ruby

Is it because of old rubocop version (0.57.2)? I can't use more modern rubocop because this version is last which supports ruby 2.1

[shir]

nevermind. Look like it's an issue with asdf which I use as ruby version manager

[wingrunr21]

Ah, mind telling me what the issue is? I'd like to support that if I can

[shir]

@wingrunr21 rubocop is run via asdf as a shim. Asdf determine which ruby version to use based on the current working directory and .ruby-version file in this directory. Maybe the issue is that the rubocop is run not within the project directory. Which directory do you use to run rubocop?

[wingrunr21]

Is the .ruby-version file in the workspace root? That's where the environment detection spawns a shell to see what the ruby environment should be in that directory.

How does asdf expose which ruby to run? Does it modify the environment?

[shir]

I made some debugging. Looks like when rubocop is called no environment variable are set. asdf depends on $HOME variable to set asdf data directory but $HOME is empty and the data directory is set to /.asdf instead ~/.asdf. And it can't find any installed plugins. Theoretically, it may be set via setting ASDF_DATA_DIR environment variable but I don't know how to set it in this case.

In a normal environment, this variable (with other configs) is set via a special script which is called from .bashrc/.bash_profile.

[shir]

Could you provide the ability to set custom environment variables for linters? I believe it will also allow to fix any issues with running rubocop with rvm too.

[wingrunr21]

The environment variables need to be whitelisted into the environment detection

[wingrunr21]

HOME is now whitelisted on v0.22.1. Can you see if that works for you?