Fix gem uninstall --user-install for symlinked HOME
#7645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
gem uninstall --user-install for symlinked GEM_HOMEgem uninstall --user-install for symlinked HOME
voxik
reviewed
May 9, 2024
deivid-rodriguez
force-pushed
the
deivid-rodriguez/user-install-symlinked-gem-home
branch
3 times, most recently
from
5ddfc59
to
58e3123
Compare
deivid-rodriguez
force-pushed
the
deivid-rodriguez/user-install-symlinked-gem-home
branch
2 times, most recently
from
2f3b98b
to
bcfdb96
Compare
Tests have two copies of b-2 installed, one in default home and another in user home. But only the one in default home was visible because of not reloading paths. The user install test was working by chance.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/user-install-symlinked-gem-home
branch
from
bcfdb96
to
7f0706a
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/user-install-symlinked-gem-home
branch
deivid-rodriguez
added a commit
that referenced
this pull request
May 16, 2024
…symlinked-gem-home Fix `gem uninstall --user-install` for symlinked HOME (cherry picked from commit 110cfd2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
gem uninstall --user-installwon't work if HOME is symlinked, which is the default on FreeBSD.What is your fix for the problem, implemented in this PR?
Make sure to expand home to its realpath.
Fixes #6457.
Make sure the following tasks are checked