Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double colons in questions asked from GemcutterUtilities #7644

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

technicalpickles
Copy link
Contributor

At some point, this is using Thor, and it automaticlaly adds a trailing : with space, so we don't need to do it ourselves.

What was the end-user or developer problem that led to this PR?

I was using https://github.com/rubygems/configure_trusted_publisher and got minorly annoyed by the double : prompts:

Enter your RubyGems.org credentials.
Don't have an account yet? Create one at https://rubygems.org/sign_up

Username/email: : pickles@example.com

      Password: : 
You have enabled multi-factor authentication. Please enter OTP code.

Code: : 12345678

What is your fix for the problem, implemented in this PR?

Update these ask calls to not include the :

Make sure the following tasks are checked

At some point, this is using Thor, and it automaticlaly adds a trailing
`:` with space, so we don't need to do it ourselves.
@technicalpickles
Copy link
Contributor Author

The tests are failing because there isn't a colon 😅 I wonder if it has to do with the thor version?

@deivid-rodriguez
Copy link
Member

I don't think RubyGems uses thor. Bundler uses thor, but uses a fixed version so even then thor version should be irrelevant. So maybe it's something else? I'm unsure about what could cause this.

@technicalpickles
Copy link
Contributor Author

Well, I can reproduce the test failure locally at least.

The place I observed it was in https://github.com/rubygems/configure_trusted_publisher ... my output is identical to the readme, ie:

$ gem exec configure_trusted_publisher rubygem
Configuring trusted publisher for rubygem0 in /Users/segiddins/Development/github.com/rubygems/configure_trusted_publisher for rubygems/configure_trusted_publisher

Enter your https://rubygems.org credentials.
Don't have an account yet? Create one at https://rubygems.org/sign_up
Username/email: : gem-author
      Password: :

  1) Automatically when a new tag matching v* is pushed
  2) Manually by running a GitHub Action

How would you like releases for rubygem0 to be triggered? (1, 2) [2]: 2

Successfully configured trusted publisher for rubygem0:
  https://rubygems.org/gems/rubygem0/trusted_publishers

Specifically, Username/email and Password have extra : in them.

@technicalpickles technicalpickles marked this pull request as draft May 13, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants