Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up generated and copied files #7632

Merged
merged 1 commit into from May 16, 2024
Merged

Conversation

nobu
Copy link
Contributor

@nobu nobu commented May 7, 2024

What was the end-user or developer problem that led to this PR?

leaving the files after gem rebuild was intentional, for local
inspection, but the test suite should be made to clean up after
itself independently of that.

#4913 (comment)

What is your fix for the problem, implemented in this PR?

Clean up generated and copied files.

Make sure the following tasks are checked

> leaving the files after gem rebuild was intentional, for local
> inspection, but the test suite should be made to clean up after
> itself independently of that.
rubygems#4913 (comment)
@deivid-rodriguez
Copy link
Member

@duckinator Can you have a second look here?

@hsbt hsbt merged commit 2d02e9e into rubygems:master May 16, 2024
75 checks passed
@hsbt
Copy link
Member

hsbt commented May 16, 2024

The current test code still remains some of garbages at ruby/ruby repo. I will merge this.

@duckinator If you have some concerns about this, can you submit another PR? Thanks.

@duckinator
Copy link
Member

This looks good to me. Thanks for taking care of this, @nobu + @hsbt -- I've been really busy this month, and wound up missing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants