Add --target-rbconfig option to gem install and gem update commands
#7628
+199
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kateinoigakukun
force-pushed
the
pr-64aa3cae6563de7b71b8cebbd2453e65e4f40278
branch
3 times, most recently
from
57df8bd
to
97fa3ff
Compare
kateinoigakukun
force-pushed
the
pr-64aa3cae6563de7b71b8cebbd2453e65e4f40278
branch
5 times, most recently
from
394788b
to
7868c67
Compare
…ands This patch adds `--target-rbconfig` option to specify the rbconfig.rb file for the deployment target platform. This is useful when cross-compiling gems. At the moment, this option is only available for `extconf.rb`-based extensions.
kateinoigakukun
force-pushed
the
pr-64aa3cae6563de7b71b8cebbd2453e65e4f40278
branch
from
7868c67
to
86a8474
Compare
kateinoigakukun
force-pushed
the
pr-64aa3cae6563de7b71b8cebbd2453e65e4f40278
branch
from
86a8474
to
132178c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Today, CRuby runs on many platforms. But not all platforms are capable of running build tools (e.g. WebAssembly/WASI), so cross-target compilation against extensions libraries is essential for those platforms.
Currently, there is no way to cross-compile extension libraries in gems at install-time.
What is your fix for the problem, implemented in this PR?
This patch adds
--target-rbconfigoption to specify the rbconfig.rb file for the deployment target platform. It basically pass through it to mkmf. The underlying--target-rbconfigsupport in mkmf has been introduced recently https://bugs.ruby-lang.org/issues/20345At the moment, this option is only available when the following requirements are met:
extconf.rb-based extensionsBut we can relax the first requirement for Cargo builder by adding a support in rb-sys later.
$ GEM_HOME=/tmp/gems-wasm32-wasi gem install nokogiri --target-rbconfig path/to/wasm32-wasi/rbconfig.rbMake sure the following tasks are checked