Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rubygem_id foreign key constraint to linksets table. #4571

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

simi
Copy link
Member

@simi simi commented Mar 31, 2024

There is 1 old linklist breaking this foreign key.

@martinemde @segiddins would you prefer to make the deletion in migration or is it ok to delete manually to keep prod DB inconsistency details out of migrations?

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.07%. Comparing base (b896042) to head (02018b6).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4571   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         390      390           
  Lines        8181     8181           
=======================================
  Hits         7942     7942           
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you fix it manually, other environments might need to be manually cleaned as well, but that seems fine as it allows local envs to clean up their own way. I'm ok with deploying this as is.

Copy link
Member

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting manually sounds right to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants