Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title text for verified links, test for verified link #4538

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martinemde
Copy link
Member

There was some confusion about what the checkmarks mean next to links on the gem page. This starts with a title text to explain, though we also probably need documentation for how people can achieve this checkmark.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (d7b5c95) to head (db014a9).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4538   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files         390      390           
  Lines        8189     8192    +3     
=======================================
+ Hits         7950     7953    +3     
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinemde
Copy link
Member Author

This is paused on discussion about how to make the divide more obvious between gemspec links and official rubygems.org links.

@simi simi added the blocked label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants