Don't use nonces in Content-Security-Policy, use hashes. #4464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a concern that provides the
inline_script
andinline_script_content
interface which allows us to declare and then render inline scripts in a way that is compatible with computing hashes.The nonce is not ideal because it gets cached by Fastly, with each page caching a different nonce based on the user requests that happened to be cached. Not very nonce-y.
This also remove the nonce hack that caused some session generation problems originally, even though they are fixed now.