Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing users with a copy-to-clipboard feature for the checksum #4353

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robbyrussell
Copy link
Contributor

When viewing an individual Rubygem version, let's make it simple for users to copy/paste the SHA 256 Checksum quickly. This change uses the existing copy/clipboard functionality.

Currently, it looks like this:

image

Proposed change:

image

2024011226

Thanks for your consideration!

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (866208a) 96.98% compared to head (3e7bbef) 96.98%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4353   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         336      336           
  Lines        7487     7487           
=======================================
  Hits         7261     7261           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simi
Copy link
Member

simi commented Jan 15, 2024

Hello @robbyrussell, it seems those I18n keys are not present in the given scope. Instead of another copy, I did small refactoring at #4354 which makes them reusable. Once merged, you can change it to t("copied") or similar to fix failing tests in here.

@simi
Copy link
Member

simi commented Jan 15, 2024

@robbyrussell #4354 got merged, can you update templates?

@robbyrussell
Copy link
Contributor Author

@simi sure thing, done!

@simi
Copy link
Member

simi commented Jan 25, 2024

@robbyrussell would you mind to fix the failing spec?

assert page.has_content?(@latest_version.sha256_hex)
It expects sha to be printed in the page content, but since it is now part of input, it fails the test. Feel free to ping me if you need help, I can try to tackle this on my own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants