Providing some context to how long ago a version was released #4352
Conversation
…ewing any gem version.
…longer timespans.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4352 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 336 336
Lines 7431 7431
=======================================
Hits 7337 7337
Misses 94 94 ☔ View full report in Codecov by Sentry. |
| @@ -15,6 +15,15 @@ | |||
| <span class="gem__downloads"><%= number_with_delimiter(@latest_version.downloads_count) %></span> | |||
| </h2> | |||
| </div> | |||
|
|
|||
| <h2 class="gem__ruby-version__heading t-list__heading"> | ||
| <%= t('.gem_version_age') %>: | ||
| <span class="gem__rubygem-version-age"> | ||
| <p><%= time_ago_in_words(@latest_version.authored_at) %> ago</p> |
There was a problem hiding this comment.
@segiddins if I understand it well, this is going to break caching, since the page content will change in time even with no resource update. Would it be better to use JS solution like https://momentjs.com/docs/#/displaying/fromnow/?
There was a problem hiding this comment.
I have found out also https://github.com/basecamp/local_time.
There was a problem hiding this comment.
@robbyrussell would you mind to try to use local_time gem? Feel free to ping me if you need help.
There was a problem hiding this comment.
I'm sorry for not considering the caching aspect that is in production.
The install instructions for the current releases of local_time assume you might have importmaps and/or webpacker in place. Are there plans for this project to use either approach going forward? (and past versions on NPM)
There was a problem hiding this comment.
No, but can't you just import one of those (https://github.com/basecamp/local_time/tree/main/app/assets/javascripts) using current pipeline (require here - https://github.com/rubygems/rubygems.org/blob/master/app/assets/javascripts/application.js)?
There was a problem hiding this comment.
@robbyrussell there is PR introducing importmaps at #4392. Maybe it is worth to wait for that one to land before tackling this.
|
@robbyrussell import maps has landed already. Are you still interested in finishing this? |
|
Assigning so I can try to get this into the design refresh that is coming. |
Proposal: When you're looking at a particular Rubygem (version), it would be nice if we could convey the age of a particular gem version.
Example:
This change uses
time_ago_in_words, and we pass in the authored_at timestamp.Considerations:
I'm not 100% confident in all the translations. I used Google Translate; it might help to have additional people review it.