Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store email using exact casing as provided by user. #4200

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

simi
Copy link
Member

@simi simi commented Nov 11, 2023

based on anuragaryan@101df67

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71e699d) 98.73% compared to head (cf21d0d) 98.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4200   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files         336      336           
  Lines        7431     7433    +2     
=======================================
+ Hits         7337     7339    +2     
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

app/models/user.rb Outdated Show resolved Hide resolved
@simi simi requested a review from segiddins November 13, 2023 23:47
@simi
Copy link
Member Author

simi commented Dec 30, 2023

@segiddins feel free to merge once you're happy.

anuragaryan and others added 2 commits January 9, 2024 04:45
* Fixes #1763
* Index on lower(email)
* Enforce uniqueness on lower(email)
* Use Case insensitive email to login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate email casing
4 participants