Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update zh-TW translation #4092

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

update zh-TW translation #4092

wants to merge 8 commits into from

Conversation

5idereal
Copy link

No description provided.

@simi
Copy link
Member

simi commented Sep 27, 2023

Hello and thanks for the pull request.

@adrianthedev Would it make sense to contribute avo translation into https://github.com/avo-hq/avo/tree/main/lib/generators/avo/templates/locales?

@khiav223577 @JuanitoFatas @hrs113355 any chance to review?

config/locales/zh-TW.yml Show resolved Hide resolved
config/locales/zh-TW.yml Outdated Show resolved Hide resolved
config/locales/zh-TW.yml Show resolved Hide resolved
@khiav223577
Copy link
Contributor

Others LGTM

@simi
Copy link
Member

simi commented Sep 29, 2023

@5idereal can you please check on suggested changes?

5idereal and others added 3 commits October 1, 2023 18:33
Co-authored-by: Rumble Huang <mrtmrt15xn@yahoo.com.tw>
Co-authored-by: Rumble Huang <mrtmrt15xn@yahoo.com.tw>
Co-authored-by: Rumble Huang <mrtmrt15xn@yahoo.com.tw>
@5idereal
Copy link
Author

5idereal commented Oct 1, 2023

Hi @simi, I've committed all the suggestions from @khiav223577.

@khiav223577 感謝您的 review!

@simi
Copy link
Member

simi commented Oct 1, 2023

Thanks! There were also some troubles on CI due to formatting, let's wait for other CI round.

@adrianthedev
Copy link
Contributor

Yes @simi. That would be great to have it in Avo.
Thank you!

5idereal and others added 2 commits October 12, 2023 10:59
Co-authored-by: Rumble Huang <mrtmrt15xn@yahoo.com.tw>
@simi
Copy link
Member

simi commented Oct 31, 2023

@5idereal sorry for the delay on this PR, can you please rebase? I'm happy to merge once done.

@5idereal
Copy link
Author

5idereal commented Nov 1, 2023

@simi should be ready for merge. can you check it again please?

@simi
Copy link
Member

simi commented Dec 30, 2023

@5idereal sorry for long delay :( Any chance to rebase this for final time please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants