Backfill linkset links to version metadata #4047
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4047 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 268 269 +1
Lines 6168 6182 +14
=======================================
+ Hits 6107 6121 +14
Misses 61 61
|
| "wiki" => "https://example.com/wiki") | ||
| end | ||
|
|
||
| should "only update the home uri" do |
There was a problem hiding this comment.
Because in the Links model we only use the home uri from the link set when version metadata has uris defined, and ignore all the other links in the link set
There was a problem hiding this comment.
So the home link is the only one that currently falls back, and if there are any URIs already in metadata, they are being ignored right now, so we don't bother to copy them. Then after this we remove that fallback and remove linkset entirely?
Makes sense, thanks for explaining.
There was a problem hiding this comment.
yeah, it's confusing. which is why i think it would be nice to get rid of link set entirely, because of the "sometimes but not always used" situation
So we can complete the migration off of linkset entirely Next step after this merges & the backfill is run is to completely stop reading/writing linksets
segiddins
force-pushed
the
segiddins/backfill-linkset-to-version-metadata
branch
from
e3a07e7
to
6162cec
Compare
So we can complete the migration off of linkset entirely
Next step after this merges & the backfill is run is to completely stop reading/writing linksets
See #1815 for context