Allow disabling specific links for specific gems via feature flag #3947
Conversation
Done so that we can disable the gem download link for metasploit, so the metasploit gem payes are not marked as malicious for linking to "malicious" content
Codecov Report
@@ Coverage Diff @@
## master #3947 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 217 217
Lines 5417 5421 +4
=======================================
+ Hits 5352 5356 +4
Misses 65 65
|
|
Good usage of LD IMO for easy updating 👍🏻 |
There was a problem hiding this comment.
Code-wise it looks ok.
In general, I'm against this change if not implemented in super-transparent (as explained at #3883 (comment)) way. That means to make it clear which pages and why are "soft-blocked". Using LaunchDarkly makes it hidden from users to find out. Storing this info info DB would be more transparent.
Per my understanding, there were no recent reports of this causing any problems to users. Do we really need to address this currently?
On the other side I'm not going to block this, feel free to ship this if there's consensus.
| @@ -66,6 +66,7 @@ | |||
|
|
|||
| <h3 class="t-list__heading"><%= t '.links.header' %>:</h3> | |||
| <div class="t-list__items"> | |||
| <code><%= @versioned_links.each.to_a.to_json %></code> | |||
There was a problem hiding this comment.
Ah debugging code, will delete
|
I think adding a flash message or banner to any page where this is taking effect sounds like a good idea. Google Safe Browsing does still block several pages on rubygems.org, as shown in the screenshot below, and that is what we are hoping to resolve. 
|
Done so that we can disable the gem download link for metasploit, so the metasploit gem payes are not marked as malicious for linking to "malicious" content
Closes #3883