api/v1/versions endpoint #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create the api/v1/versions endpoint.
micheelengronne
changed the title
| results.group_by {|r| r[:name] }.each do |gem, rows| | ||
| requirements = rows.group_by {|r| [r[:number], r[:platform]] } | ||
|
|
||
| value = requirements.map do |version, r| |
There was a problem hiding this comment.
Would this do the right thing?
Suggested change
| value = requirements.map do |version, r| | |
| value = requirements.map do |(version_number, platform), r| |
Well, version_number is perhaps a too-long name, could call it version, too?
There was a problem hiding this comment.
agreed. I changed it in the following commit. eb619cd
|
The CI is broken for months in the master branch. Is this project still alive ? I would like to contribute on it as I use it internally but if it is not maintained, do you know any opensource alternatives (and not a all-in-one solution like artifactory) ? |
olleolleolle
reviewed
Oct 8, 2023
| context "from the default upstream" do | ||
| let(:current_env) { Gemstash::Env.current } | ||
| let(:upstream) { Gemstash::Upstream.new(current_env.config[:rubygems_url]) } | ||
| let(:storage) { Gemstash::LocalStorage.for("gem_cache").for(upstream.host_id) } |
There was a problem hiding this comment.
I think this can become
Suggested change
| let(:storage) { Gemstash::LocalStorage.for("gem_cache").for(upstream.host_id) } | |
| let(:storage) { Gemstash::Storage.for("gem_cache").for(upstream.host_id) } |
|
|
||
| context "from private gems" do | ||
| let(:gem_source) { Gemstash::GemSource::PrivateSource } | ||
| let(:storage) { Gemstash::LocalStorage.for("private").for("gems") } |
There was a problem hiding this comment.
Suggested change
| let(:storage) { Gemstash::LocalStorage.for("private").for("gems") } | |
| let(:storage) { Gemstash::Storage.for("private").for("gems") } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the api/v1/versions endpoint.
Description:
This endpoint is needed to integrate gemstash in automated systems.
Tasks:
I will abide by the code of conduct.