New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rails credentials support #355
base: master
Are you sure you want to change the base?
Add rails credentials support #355
Conversation
a24c238
to
61810ff
Compare
I'm currently having trouble with different ruby version in the test, any clue ? |
Not 100% sure what's going on with the tests on CI. Tests pass for me locally. I suspect it has something to do with Rails 7.0 or 7.1 because we don't run tests for those Rails versions when running the test suite for Ruby 2.7, jruby, or truffleruby. I merged in a change that address the deprecation warnings for |
075d284
to
ef7ccc8
Compare
Update: Rebased to latest master I look around and found the solution for rails 7.1 fail test. For Rails 7.1 and above it seems we need to use All test should pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Requested a few changes
36b06f6
to
f67fadf
Compare
Update:
aws:
secret_access_key: '123456' Apparently we don't need to check for rails version, just need to require the master_key in test environment and for rails5.2 untiil 6.1 need test.key and master.key, otherwise it somehow ignore the |
@cjlarose let me know if there is anything else require. |
utilize ActiveSupport::EncryptedConfiguration config method
4eddca8
to
de1bb93
Compare
Added rails credentials support with config flag addressing #68