Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace with std::string_view for C++17 #221

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Replace with std::string_view for C++17 #221

wants to merge 8 commits into from

Conversation

gabyx
Copy link
Contributor

@gabyx gabyx commented Jan 26, 2019

No description provided.

@gabyx
Copy link
Contributor Author

gabyx commented Jan 27, 2019

unknown warning group '-Wself-assign-overloaded', ignored
I needed to disable this warning in the test: need to turn that on for clang greater then a specific version...
for clang 7.0 it does not work.

@coveralls
Copy link

coveralls commented Jan 27, 2019 •
edited

Coverage Status

Coverage decreased (-0.03%) to 92.254% when pulling d4f31cd on gabyx:feature/remove-string-view into b3a131c on rttrorg:master.

@gabyx
Make USE_LATEST_STD cmake option.-
d4f31cd 
Determine minimum cxx standard for library.
@gabyx
Copy link
Contributor Author

gabyx commented Jan 27, 2019

I included a cmake options USE_LATEST_STD which make the library if MAX_CXX_VERSION is >= 17 using std::string_view which adjusts the minimum version to 17.

@mapron
Copy link

mapron commented Jul 4, 2020

Oh, here ia the answer why RTTR uses own string_view. Any progress on this MR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabyx @coveralls @mapron