Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make callbacks consistent for storage access api #60

Merged
merged 2 commits into from Mar 13, 2024
Merged

Fix: Make callbacks consistent for storage access api #60

merged 2 commits into from Mar 13, 2024

Conversation

mayan-000
Copy link
Contributor

Description

This PR aims to fix the inconsistent cookie data update on callbacks, removing error messages when the user has access.

  • Remove callback on load preferences function.
  • Clear error messages on any button/input interaction.
  • Updates the code flow into an async-await IIFE function for better management.
Screen.Recording.2024-03-13.at.3.25.25.PM.mov

@mayan-000 mayan-000 self-assigned this Mar 13, 2024
fellyph
fellyph approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@fellyph fellyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fellyph fellyph merged commit 15dec24 into develop Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fellyph fellyph fellyph approved these changes

@gagan0123 gagan0123 Awaiting requested review from gagan0123

Assignees

@mayan-000 mayan-000

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mayan-000 @fellyph