Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ompgsql: In case of PG not available lets retry instead of dropping messages. #5370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickolai-dr
Copy link

Messages are lost in case of temporary PG operation errors, since RS_RET_SUSPENDED not propagated outside.

Possibly related to #1105

@nickolai-dr nickolai-dr force-pushed the retry-if-pgsql-not-avaialble branch from ecd758f to aa8b652 Compare May 1, 2024 19:52
@nickolai-dr nickolai-dr changed the title In case of PG not available lets retry instead of dropping messages. ompgsql: In case of PG not available lets retry instead of dropping messages. May 1, 2024
@nickolai-dr
Copy link
Author

Not sure how fixe code cov thing, my changes are not related to ElasticSearch...

============================================================================
See tests/test-suite.log
Please report to rsyslog@lists.adiscon.com
============================================================================
make[3]: *** [test-suite.log] Error 1
make[2]: *** [check-TESTS] Error 2
make[1]: *** [check-am] Error 2
make: *** [check-recursive] Error 1
make[3]: Leaving directory `/var/lib/buildbot/slave/rsyslog_ElasticSearch_codecov/build/tests'
make[2]: Leaving directory `/var/lib/buildbot/slave/rsyslog_ElasticSearch_codecov/build/tests'
make[1]: Leaving directory `/var/lib/buildbot/slave/rsyslog_ElasticSearch_codecov/build/tests'
program finished with exit code 2

plugins/ompgsql/ompgsql.c Outdated Show resolved Hide resolved
@rgerhards
Copy link
Member

Not sure how fixe code cov thing, my changes are not related to ElasticSearch...

This looks like a flake, I have re-initiated the run. I'll also enable the rest of the CI now. Note that there are some timing-related flakes. I'll watch out for them. If you see somthing not related to your patch, no need to worry (I'll take care).

Note that I am currently busy with other work and can probably not babysit CI until next week.

@rgerhards rgerhards self-assigned this May 2, 2024
@rgerhards rgerhards added this to the v8.2406 milestone May 2, 2024
@rgerhards rgerhards added the bug label May 2, 2024
@nickolai-dr nickolai-dr force-pushed the retry-if-pgsql-not-avaialble branch from aa8b652 to 3e5a893 Compare May 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants