Patch base S3 dispatch table directly for R Notebook S3 overrides #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinushey
reviewed
May 9, 2018
|
|
||
| if (getRversion() < "3.5") { |
There was a problem hiding this comment.
Do the objects created by running this code get cached somewhere (and then reloaded for subsequent sessions)? (Just want to make sure that it's not possible for someone to end up with R 3.5 components when running with R 3.4)
There was a problem hiding this comment.
No, I don't believe so. We source the module .R files, including this one, at the beginning of every session, whether new or resumed.
jmcphers
force-pushed
the
bugfix/r-3.5-notebooks
branch
from
9ffcab2
to
edbc775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R 3.5 includes a breaking change which prevents tables and HTML widgets from appearing in R Notebook chunks. The change is this (from NEWS):
In order to capture printed tables and HTML widgets, we create S3 methods in the
tools:rstudioenvironment, which are used in favor of the base methods since they precede them on thesearch()path. However, starting in R 3.5, the namespace registry is searched first instead, so our S3 methods are never executed.There no longer appears to be an elegant way to create short-lived S3 overrides of the kind used in the notebook, so with this change we take a longer route: we patch the S3 dispatch table directly (and temporarily) to use our methods. This should work for any R version, but for caution's sake we're continuing to use the known-good lower-touch mechanism in releases of R older than 3.5.
Fixes #2748.