Fixed socket proxy crash issue caused by double closing sockets #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, so glad to see a fix for this! |
jmcphers
reviewed
Feb 20, 2018
src/cpp/core/http/SocketProxy.cpp
Outdated
| // and can (and has) lead to segfaults | ||
| if (!closed_) | ||
| { | ||
| ptrClient_->close(); |
There was a problem hiding this comment.
Do you think we should store the closed state in the individual Socket instances instead? Then we could defend against other code paths which inadvertently double-close a Socket (rather than just the SocketProxy)
There was a problem hiding this comment.
Sounds good. I'll take a look.
This reverts commit d986b9c. Conflicts: src/cpp/core/http/SocketProxy.cpp
…ocket implementations so higher level protocols do not have to worry about double close
|
@jmcphers Updated. |
jmcphers
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2061