explicitly ignore '.git' folder on Windows #2148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcphers
reviewed
Feb 7, 2018
| { | ||
| // screen out '.git' folder | ||
| if (fileInfo.isDirectory() && | ||
| boost::algorithm::ends_with(fileInfo.absolutePath(), ".git")) |
There was a problem hiding this comment.
Nit: this will screen out foo.git and bar.git as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to resolve an issue where attempts to launch the IDE could fail if the
.gitfolder was not marked as hidden. Effectively, the IDE would get deadlocked between the file monitor scanning for changes to the.git/index.lockfile, and attempts to callgit statusto populate the Git pane.Resolves #2141.
@jjallaire, let me know if this feels like the right change or if there's a more appropriate place for this fix to live.
Do we want to be resilient against other hidden folders that may become unhidden (e.g. the
.Rproj.userfolder)?