candidate fix for slowness on NFS #1758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a candidate fix for the slowness observed by some Windows users running on networked filesystems, re: #1592.
In v1.1, we introduced a feature that attempts to respect a parent project configuration when opening a file located outside of the current project. We do this by looking up the filesystem for files with the extension
.Rproj
, which implies recursively listing the contents of directories until a directory is found.Unfortunately, there were two problems:
Newly-created documents don't have a path; calling
resolveAliasedPath()
on those returns the home directory;We never anchored the lookup to a suitable path (ie, the user's home directory, or the parent of that directory)
This meant that opening a new file would trigger a recursive listing of all files within the home directory (and parent directory where permissions allowed), and I suspect this may be a very slow operation on certain NFS configurations.
This PR attempts to alleviate both issues.
This is a candidate for the v1.1 patch release, if we can confirm it does alleviate the slowness observed.