Fix client-side terminal alt-buffer detection #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by update to xterm.js 2.9.2 internals, which I took late in 1.1 cycle. So close to getting away with it relatively unscathed! :-(
Resolves #1725
Regression caused Ctrl+L to clear entire terminal even when running a full-screen program such as tmux, which does its own handling of Ctrl+L to clear the current pane, instead. Essentially, Ctrl+L messes up full-screen programs and prevents them from doing what they want with Ctrl+L.
Also messed up which commands display in upper-right of Terminal toolbar (stop and clear should be hidden when running full-screen program, but they aren't).