Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid querying clipboard while modal active #1611

Merged
merged 1 commit into from Oct 16, 2017
Merged

Conversation

kevinushey
Copy link
Contributor

This should fix #1587.

@krlmlr
Copy link
Contributor

krlmlr commented Oct 15, 2017

If you could make a .deb available, I can give it a try. The most recent nightly doesn't fix the problem yet (of course).

As a side note, the clipboard override that happens in the affected routine looks dubious to me. I did notice the "\x01" characters appearing in the clipboard under some circumstances, but maybe there's a way to fix this problem at the root? The problem didn't affect me that much because I'm using a clipboard ring -- if we can't fix at the root and need to work around, maybe the RStudio IDE could implement a clipboard ring internally and filter the "\x01" when pasting (and also when the main window loses focus)?

@jmcphers jmcphers merged commit 68aba2d into master Oct 16, 2017
@lepennec
Copy link

I can confirm it solves the issue with Fedora 26. Thanks!

@krlmlr
Copy link
Contributor

krlmlr commented Oct 23, 2017

Thanks! Solves the problem for me in Ubuntu GNOME.

@cranedroesch
Copy link

Glad you guys have fixed the problem, but would appreciate if you could let me (and my fellow muggles) know how to access your fix. It's not a problem solved by apt-get update && apt-get upgrade yet.

@rmflight
Copy link

@cranedroesch probably by installing a daily build from https://dailies.rstudio.com/

@valerie-rstudio valerie-rstudio deleted the bugfix/slow-file-dialog branch January 21, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Open dialog slow on RStudio Desktop for Linux
7 participants