Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of Sexpr for sweave #14384

Merged
merged 3 commits into from Mar 7, 2024
Merged

Conversation

kevinushey
Copy link
Contributor

Intent

Addresses #14382.

Approach

Update the Sweave highlight rules, to use the new (and more robust) context object for storing tokenizer state.

Automated Tests

N/A

QA Notes

Test via notes in #14382.

Documentation

N/A

Checklist

  • If this PR adds a new feature, or fixes a bug in a previously released version, it includes an entry in NEWS.md
  • If this PR adds or changes UI, the updated UI meets accessibility standards
  • A reviewer is assigned to this PR (if unsure who to assign, check Area Owners list)
  • This PR passes all local unit tests

Copy link
Member

@gtritchie gtritchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinushey kevinushey merged commit b46c001 into main Mar 7, 2024
@kevinushey kevinushey deleted the bugfix/sweave-sexpr-highlight branch March 7, 2024 18:15
@nickreich
Copy link

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants