New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempts to print tbl_dfs as paged tables in Notebooks fail with R 3.5. #2748
Comments
This might meet the bar for v1.1-patched just because it also implies the generated Notebook output is wrong (since v1.1 doesn't understand how to render console output with ANSI escape sequences) |
A similar issue happens with leaflet output: the output used to go below the window, below the chunk, now it always goes to the viewer (like in non-notebook mode).
Do you think it's the same issue? sessionInfo:
|
Does anyone have an idea on how we could force a "print as a paged table" while we wait on the bug fix? |
I’m using the It doesn’t fix the leaflet issue (again, if it’s the same problem). If the fix is for v1.2, are we more talking a few weeks or 6 months? Just to know if I should rollback to 3.4.4 |
I can't give a timeframe, but this will be a pretty high priority bug so we hope to tackle it ASAP and get it into the daily builds + a preview release of RStudio in due course. |
The leaflet issue is indeed the same problem; both are caused by the change in R 3.5. I've just made a fix for this which should be in the dailies shortly. We'll also backport it to 1.1 as soon as we've validated it, as without it R 3.5 users will not be able to use some notebook features. |
Thanks! |
… On Thu, May 10, 2018 at 6:52 AM, gregleleu ***@***.***> wrote:
Thanks!
There's no compiled dailies, right? The way to get it would be to build
from source?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2748 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAfafZ00ynIPVfB6fpWVcTX9bR2MKuvkks5txBwAgaJpZM4TzySF>
.
|
I installed the latest packages and RStuido (Windows), but still has the same problem. Also, the table in Preview was not rendered. Thanks. |
It looks like the Windows build failed yesterday so the fix wasn't
necessarily available there.
…On Thu, May 10, 2018 at 7:08 AM, JJ Allaire ***@***.***> wrote:
https://dailies.rstudio.com
On Thu, May 10, 2018 at 6:52 AM, gregleleu ***@***.***>
wrote:
> Thanks!
> There's no compiled dailies, right? The way to get it would be to build
> from source?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#2748 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAfafZ00ynIPVfB6fpWVcTX9bR2MKuvkks5txBwAgaJpZM4TzySF>
> .
>
|
I tried the new windows build today, but the table in notebook was still not rendered... |
@Jiang-Li Can you share the code that's reproducing the problem for you? |
@jmcphers Oh it works when I removed the kable(). But previously, the kable also worked, for example:
|
@Jiang-Li Thanks, that's helpful. Today's stable version should work for you: |
There's still an issue with |
Verified in Windows 1.2.747 and Mac 1.2.747-3. |
System details
Steps to reproduce the problem
Try running the following chunk in an R Notebook:
Describe the problem in detail
The table is printed as 'plain'
tibble
output, rather than as a paged table.Describe the behavior you expected
This should be printed as a paged table.
Diagnosis
From rstudio/rmarkdown#1331:
Something appears to be going awry with S3 dispatch in the Notebook context. One can see the issue by attempting to debug the
print
call in a Notebook chunk, using R 3.5.0 with RStudio v1.2:When running this, I see:
So it appears like the S3 override we've registered should be in scope for this print call. However, this is not the case -- the S3 method registered in
tibble
is called instead.The NEWS file of R 3.5.0 has this:
So it seems like R has explicitly switched up the mechanism used for S3 dispatch, and this has broken the way we override the S3 methods when injecting our own printers. We'll have to think about how to accommodate this change in behavior.
The text was updated successfully, but these errors were encountered: