New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal disconnects when running server in Docker #1844
Comments
It also happens when running rstudio server in AWS EC2 Ubuntu instance and it's really annoying |
Investigation notes In the repro I get on rstudio.cloud, here's the terminal diagnostics: 2017/12/15 9:16:45: WebSocket connected In the second stage (websocket closed), which looks like it happens after five minutes of inactivity, the reported behavior takes place. Typing in terminal is a no-op, and the Javascript console shows: If I wait for the "disconnected" state to take place, then the terminal will reconnect the way it is supposed to. |
Fixes #1844 If the websocket was closed (seeing this happen in container scenarios), mark the terminal as disconnected so the reconnection logic kicks in. For example, terminal should reconnect if the user types in the disconnected terminal. Prior to this fix, the terminal would remain inactive and ignore input if the underlying websocket had closed.
Fixes #1844 If the websocket was closed (seeing this happen in container scenarios), mark the terminal as disconnected so the reconnection logic kicks in. For example, terminal should reconnect if the user types in the disconnected terminal. Prior to this fix, the terminal would remain inactive and ignore input if the underlying websocket had closed.
Backported to 1.1 in d2bcc3b. |
@andresrcs, there’s a preview release at |
@ronblum, I had some problems installing it, because installation fails with python 3.6 I had to change my python3 alternatives to 3.5 but... The terminal reconnects! |
Excellent @andresrcs, thank you! |
From community: https://community.rstudio.com/t/button-to-re-connect-to-terminal-in-rstudio-server-terminal-tab/3485
I have also repro'd this in a docker scenario. Needs further investigation to determine why the terminal isn't automatically reconnecting (the intended behavior).
The text was updated successfully, but these errors were encountered: