Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal websocket closed by proxy due to inactivity #1860

Closed
gtritchie opened this issue Dec 15, 2017 · 2 comments · Fixed by #2369
Closed

Terminal websocket closed by proxy due to inactivity #1860

gtritchie opened this issue Dec 15, 2017 · 2 comments · Fixed by #2369
Assignees
Milestone

Comments

@gtritchie
Copy link
Member

gtritchie commented Dec 15, 2017

Running RStudio Server behind a proxy configured with a read-timout (for example, nginx with proxy_read_timeout option). Start a terminal session using websockets. Now don't do anything in RStudio and wait for the timeout to expire.

Ideally, terminal should send occasional keepalive messages, but currently it does not. So, this may appear in the console, and websocket is closed.

[fatal] handle_write_frame error: websocketpp.transport:10 (A transport action was requested after shutdown)

Now, due to #1844, terminal cannot be used.

We should consider a websocket keepalive message to prevent websocket death, but don't want it to also keep the rsession alive.

We also have reports of this from containerized hosting of RStudio Server.

@gtritchie gtritchie self-assigned this Dec 15, 2017
@gtritchie gtritchie added this to the v1.2 milestone Feb 26, 2018
@gtritchie
Copy link
Member Author

Bumping up priority. This shows up frequently in rstudio.cloud.

@dfalty
Copy link

dfalty commented Mar 21, 2018

Verified 1.2.451-1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants