save documents before publishing them; fixes #1821

src/gwt/src/org/rstudio/studio/client/rsconnect/ui/RSConnectPublishButton.java

@@ -174,6 +174,11 @@ public void onEnabledChanged(AppCommand command)
       events_.addHandler(RPubsUploadStatusEvent.TYPE, this);
    }
 
+   public void onPublishInvoked(Command onPublishInvoked)
+   {
+      onPublishInvoked_ = onPublishInvoked;
+   }
+
    @Override
    public void setVisible(boolean visible)
    {
@@ -365,8 +370,13 @@ public void invokePublish()
 
    // Private methods --------------------------------------------------------
 
+
    private void onPublishButtonClick()
    {
+      // let host know if requested
+      if (onPublishInvoked_ != null)
+         onPublishInvoked_.execute();
+
       // if the publish button is clicked without the droplist ever being 
       // invoked, then we need to grab the list of existing deployments to
       // determine what the default one will be.
@@ -838,6 +848,7 @@ public void onError(ServerError error)
    private boolean visible_ = false;
 
    private final AppCommand boundCommand_;
+   private Command onPublishInvoked_;
 
    private RSConnectDeploymentRecord defaultRec_;
 

src/gwt/src/org/rstudio/studio/client/workbench/views/source/editors/text/TextEditingTargetWidget.java

@@ -410,6 +410,7 @@ public void onValueChange(ValueChangeEvent<Boolean> event)
          publishButton_ = new RSConnectPublishButton(
                RSConnectPublishButton.HOST_EDITOR,
                RSConnect.CONTENT_TYPE_APP, false, null);
+         publishButton_.onPublishInvoked(() -> target_.save());
          toolbar.addRightWidget(publishButton_);
       }