Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax tests on tidyselect error messages #527

Merged
merged 5 commits into from Mar 11, 2024

Conversation

yjunechoe
Copy link
Collaborator

@yjunechoe yjunechoe commented Mar 11, 2024

Summary

I just decided to relax all tests on tidyselect error messages in this PR - we already have tests for them where it matters (reading the eval errors on the agent), so testing for error messages directly from expect_() and test_() functions are a bit redundant.

There are just two tests in 75cf1fb where it might be nice to have snapshot tests for (to check whether we're re-throwing the most informative errors), but I'm leaning towards not doing that at least for now since it's not critical to pointblank's behavior.

I also factored out all tidyselect related functions out of utils.R into utils-tidyselect.R to keep track of them in one place.

devtools::test(filter = "tidyselect") now pass both release and dev versions of {tidyselect}

Related GitHub Issues and PRs

Checklist

Fixes: #526

@rich-iannone rich-iannone self-requested a review March 11, 2024 18:28
@rich-iannone
Copy link
Member

Thanks so much for getting this prepared so quickly! Will merge and then prepare this package for a patch release.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit a57780f into rstudio:main Mar 11, 2024
12 of 13 checks passed
@yjunechoe yjunechoe deleted the tidyselect-snapshot-test branch March 11, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pointblank and tidyselect 1.2.1
2 participants