relax tests on tidyselect error messages #527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just decided to relax all tests on tidyselect error messages in this PR - we already have tests for them where it matters (reading the eval errors on the agent), so testing for error messages directly from
expect_()
andtest_()
functions are a bit redundant.There are just two tests in 75cf1fb where it might be nice to have snapshot tests for (to check whether we're re-throwing the most informative errors), but I'm leaning towards not doing that at least for now since it's not critical to pointblank's behavior.
I also factored out all tidyselect related functions out of
utils.R
intoutils-tidyselect.R
to keep track of them in one place.devtools::test(filter = "tidyselect")
now pass both release and dev versions of{tidyselect}
Related GitHub Issues and PRs
Checklist
testthat
unit tests totests/testthat
for any new functionality.Fixes: #526