Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pointblank and tidyselect 1.2.1 #526

Closed
lionel- opened this issue Mar 11, 2024 · 1 comment · Fixed by #527
Closed

pointblank and tidyselect 1.2.1 #526

lionel- opened this issue Mar 11, 2024 · 1 comment · Fixed by #527
Assignees
@rich-iannone
Labels
Difficulty: [2] Intermediate Effort: [2] Medium Priority: ♨︎ Critical Type: ☹︎ Bug
Milestone
v0.12.1

Comments

@lionel-
Copy link

lionel- commented Mar 11, 2024

The next version of tidyselect that I'm about to release will cause CRAN failures for pointblank because its tests are checking for exact matches of error messages generated in tidyselect and these have now changed. Since error message contents aren't part of the tidyselect API, could you please use testthat snapshots instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rich-iannone rich-iannone

Labels
Difficulty: [2] Intermediate Effort: [2] Medium Priority: ♨︎ Critical Type: ☹︎ Bug
Projects
None yet
Milestone
v0.12.1
Development

Successfully merging a pull request may close this issue.

relax tests on tidyselect error messages yjunechoe/pointblank
2 participants
@lionel- @rich-iannone