New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generic overload of TaskBuilderV2.For method #32

Open

SLAVONchick wants to merge 2 commits into rspeele:master from SLAVONchick:master

SLAVONchick commented May 16, 2020 •

edited

This PR solves problem of iterating over sequences that don't implement IEnumerable<'T>, e.g. System.Buffers.ReadOnlySequence<'T>.

After applying the changes you should be able to compile code like this:

open System.Text
open System.Buffers
open FSharp.Control.Tasks.V2

let readFromSequence (seq: ReadOnlySequence<byte>) = task {
    for segment in seq do 
        printfn "%s" <| Encoding.UTF8.GetString segment.Span
}

Please, @rspeele, give some feedback.

Viacheslav Koryagin added 2 commits

May 16, 2020 17:31


          added generic implementation of for loop

e2c6938


          added an extra underscore in order to compile by F# <= 4.5

c6d67f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment