Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides fragmentation and reassembly #177

Merged
merged 1 commit into from Aug 19, 2021

Conversation

olme04
Copy link
Contributor

@olme04 olme04 commented Jul 15, 2021

NOTE: Depends on #176

  • fixes Fragmentation and Reassembly #83
  • move all frame sending functionality into separate class (for future: may be don't use Frame class there, and just build final packet with frame, which will be sent to connection)
  • implement fragmentation in FrameSender.sendFragmented for request frames
  • implement simple reassembly logic in FrameHandler - TODO some improvements can be added here, like additional checking of consistency like in rsocket-java
  • minimal tests added for fragmentation and reassembly - TODO need to add more tests
  • TODO need to add more tests for leaked buffers in case of failures

@OlegDokuka OlegDokuka marked this pull request as ready for review July 22, 2021 11:33
@OlegDokuka OlegDokuka changed the title Fragmentation and reassembly provides fragmentation and reassembly Aug 19, 2021
@OlegDokuka OlegDokuka merged commit d404ee6 into rsocket:master Aug 19, 2021
@olme04 olme04 deleted the fragmentation branch August 19, 2021 13:43
@olme04 olme04 mentioned this pull request Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fragmentation and Reassembly
2 participants