Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added material UI icons and one as an example for Schedule #223

Closed
wants to merge 4 commits into from

Conversation

Freshenext
Copy link
Collaborator

No description provided.

Copy link
Member

@jessgusclark jessgusclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get this to work in IOS, after i install I get an error about the target build type. Is there something else that I need to change?

Then, can we add this icon somewhere so we can test that it works. I tried to add it but nothing showed up.

@@ -0,0 +1,9 @@
// @ts-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line and instead install the types for this package:

yarn add @types/react-native-vector-icons --dev

import MaterialIcon from 'react-native-vector-icons/MaterialIcons'
import React from 'react'

const ScheduleIcon = (props?: object) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have the types, we can do this:

const ScheduleIcon = (props?: IconProps) => (

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, verify.

Fixed an issue with a default export in index.tsx for icons.
Created interface for the mui icons that we'll use across the app.
@jessgusclark
Copy link
Member

Hey @lucachaco , please try to run this. If you get an error about duplicating/coping font files for IOS, try to resolve it with this: oblador/react-native-vector-icons#1074 (comment)

OR, re-clone and reinstall. I believe it is a caching issue.

@lucachaco
Copy link
Contributor

i got this
image

@jessgusclark
Copy link
Member

Thank you @lucachaco I got this error as well. I think this has to do with the initial install and if you re-yarn install the app but I'm not 100% sure. We need to investigate what is happening before we can merge this.

@jessgusclark jessgusclark mentioned this pull request Jun 24, 2022
4 tasks
@jessgusclark
Copy link
Member

Closing in favor of #230 which started with these commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants